Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Seraphim SACU Enhancement Script #6518

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Update Seraphim SACU Enhancement Script #6518

merged 6 commits into from
Nov 18, 2024

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Nov 7, 2024 •
edited
Loading

Following on the changes of #6498

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

Garanas
Garanas requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in basic annotations, see also:

@MrRowey MrRowey marked this pull request as draft November 11, 2024 13:30
@MrRowey MrRowey requested a review from Garanas November 12, 2024 18:14
@MrRowey MrRowey marked this pull request as ready for review November 13, 2024 16:47
@lL1l1
Copy link
Contributor

lL1l1 commented Nov 18, 2024

Had to fix the wrong PR number being added to the snippet in the merge.

@lL1l1 lL1l1 merged commit d9e49e7 into FAForever:develop Nov 18, 2024
5 checks passed
@lL1l1 lL1l1 added the area: code style code refactoring label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garanas Garanas Garanas approved these changes

Assignees
No one assigned
Labels
area: code style code refactoring
Projects
None yet
Milestone
Development iteration III of 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@MrRowey @lL1l1 @Garanas