Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solace torpedo damage #6522

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −3
Open

Fix Solace torpedo damage #6522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c6647
Fix Solace torpedo damage
Tagada14 Nov 9, 2024
c05af24
Add changelog snippet
Tagada14 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/snippets/balance.6522.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- (#6522) In #5725 the number of child projectiles was accidentally increased from 2 to 3 resulting in increased total damage (6k rather than 4k). This change was reversed and the damage is now properly split between child projectiles as well. To compensate the original projectile damage was multiplied by the number of child projectiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- (#6522) In #5725 the number of child projectiles was accidentally increased from 2 to 3 resulting in increased total damage (6k rather than 4k). This change was reversed and the damage is now properly split between child projectiles as well. To compensate the original projectile damage was multiplied by the number of child projectiles.
- (#6522) In #5725 (version 3777, December 2023) the number of child projectiles for the Solace was accidentally increased from 2 to 3 resulting in increased total damage (6k rather than 4k). This change is reversed, and the damage is now properly split between child projectiles as well. To compensate, the original projectile damage is multiplied by the number of child projectiles.

In addition, the technical details about how the projectile damage is split may not be necessary, since the noticeable gameplay change is that the projectiles now deal full damage if they hit an enemy before entering the water.


- Solace: T3 Torpedo Bomber (XAA0306)
- Total Damage: 6000 --> 4000
8 changes: 6 additions & 2 deletions projectiles/AANTorpedoCluster01/AANTorpedoCluster01_script.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ AANTorpedoCluster01 = ClassProjectile(ATorpedoCluster) {
OnEnterWater = function(self)
ATorpedoClusterOnEnterWater(self)

-- create child projectiles
local bp = self.Blueprint.Physics
local numProjectiles = bp.Fragments
for i = 0, numProjectiles do

-- split damage over each child
self.DamageData.DamageAmount = self.DamageData.DamageAmount / numProjectiles

-- create child projectiles
for i = 0, (numProjectiles - 1) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confused me at first, could you do this?

for i = 1, numProjectiles do

proj = self:CreateChildProjectile(bp.FragmentId)
proj.DamageData = self.DamageData
end
Expand Down
2 changes: 1 addition & 1 deletion units/XAA0306/XAA0306_unit.bp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ UnitBlueprint{
AutoInitiateAttackCommand = true,
BallisticArc = "RULEUBA_None",
CollideFriendly = false,
Damage = 400,
Damage = 800,
DamageType = "Normal",
DisplayName = "Torpedo Cluster",
FireTargetLayerCapsTable = {
Expand Down
Loading