Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASF armor against Ahwassa bomb #6530

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Nov 11, 2024

Reasoning for the changes

Since a delay was added to the Ahwassa bomb, it is possible to micro ASF out of the explosion, and the armor against it is no longer necessary.

Description of the proposed changes

  • Removes the armor type: I don't think anyone outside of FAF was using the damage type for this specific balance feature.
  • Changes the Ahwassa bomb's damage type to normal.

Testing done on the proposed changes

  • Checked that the damage type is not mentioned anywhere.
  • Verified that ASF take full damage
  • Verified that it is possible to move out of range of a ground fired bomb's explosion even if it lands on top of the ASF
    • Note: since the damage radius is spherical, the high altitude of ASFs means that the bomb actually has as small effective blast radius against ASF, about half the ground radius.

Checklist

- [ ] Changes are annotated, including comments where useful

  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: balance related to units balance label Nov 11, 2024
@lL1l1 lL1l1 marked this pull request as ready for review November 11, 2024 14:47
@Garanas
Copy link
Member

Garanas commented Nov 11, 2024

I totally agree 😃 .

@Rhaelya Rhaelya merged commit de6d833 into FAForever:develop Nov 21, 2024
5 checks passed
@Garanas
Copy link
Member

Garanas commented Nov 24, 2024

Looks like a great commit message @Rhaelya , good job 👍 . Left out the unnecessary details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants