Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate ping and buildanchored commandmode #6652

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Feb 13, 2025

Description of the proposed changes

Annotate these less often used and weird command modes.

  • ping mode:

    • does not get cancelled by right click like other modes
    • passes data from StartCommandMode to EndCommandMode on left/right click without any modifications
  • buildanchored mode: restrictive, inaccurate, and unpolished version of build mode.

Testing done on the proposed changes

  • check the engine for 'ping' string to be a command mode. If any other string is used in StartCommandMode the engine will give a warning (CUIActionHandler::GetLeftMouseButtonAction got invalid commandMode: %s), which can be used to find where all the strings are checked (func at 0x0081F7B0).
  • log the IsCancel param and click around with various command modes.
  • Test buildanchored mode with multiple/single ACUs building a factory and a T1 pd.
import('/lua/ui/game/commandmode.lua').StartCommandMode("buildanchored", { name='uab0101' })

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added area: ui Anything to do with the User Interface of the Game type: intellisense labels Feb 13, 2025
@lL1l1 lL1l1 marked this pull request as ready for review February 13, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game type: intellisense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant