Close automated attack move loophole #6653
Open
+73
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The attack move sim callback relies on position data written in lua on the user side, which allows for automation of attack move orders.
Description of the proposed changes
Thanks to an engine patch the sim can inspect a unit's command queue.
Testing done on the proposed changes
An unavoidable part of the implementation since the very beginning is that the unit queue is filled with useless script commands, so the unit is slightly unresponsive as it goes through the script command before moving on to the attack move task.
Checklist