Refactor weapon turret setup validation #6662
Open
+141
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When turret setup fails it does not give very clear information because the error messages are vague or the stack trace is incorrect due to bone validation itself erroring. Most commonly this occurs when developing mods.
Description of the proposed changes
error
toreturn
.false
.Testing done on the proposed changes
Remove bones for a unit's turret setup and check the new warning message.
Checklist