De-static GPGNetServer #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GodFuper
reviewed
Dec 8, 2024
GodFuper
reviewed
Dec 8, 2024
ice-adapter/src/main/java/com/faforever/iceadapter/gpgnet/GPGNetServer.java
Outdated
Show resolved
Hide resolved
Brutus5000
force-pushed
the
feature/destatic-GPGNetServer-class
branch
from
1e356b6 to
0082f26
Compare
GodFuper
reviewed
Dec 8, 2024
| try { | ||
| // The socket declaration must not be moved into a try-with-resources block, as the socket must not be | ||
| // closed. It is passed into the GPGNetClient. | ||
| Socket socket = serverSocket.accept(); |
There was a problem hiding this comment.
Maybe can create a constructor in the GPGNetClient(ServerSocket serverSocket) and get a socket in the constructor code. Assuming that the client should close the socket, and not try close in try/catch.
There was a problem hiding this comment.
I am not even sure why it is split up in 2 classes. 1 class is probably sufficient and then keeps the reference to the socket. But that is out of scope of this PR.
GodFuper
reviewed
Dec 8, 2024
ice-adapter/src/main/java/com/faforever/iceadapter/gpgnet/GPGNetServer.java
Outdated
Show resolved
Hide resolved
Brutus5000
force-pushed
the
feature/destatic-GPGNetServer-class
branch
from
0082f26 to
a12e90f
Compare
|
Now you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.