Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Twilio references #981

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Remove all Twilio references #981

merged 2 commits into from
Nov 5, 2023

Conversation

Brutus5000
Copy link
Member

FAF nevers used the Twilio service + it has been discontinued

@Brutus5000 Brutus5000 force-pushed the feature/remove-twilio branch from 43a2f15 to 8ead46c Compare November 4, 2023 16:23
FAF nevers used the Twilio service + it has been discontinued
@Brutus5000 Brutus5000 force-pushed the feature/remove-twilio branch from 8ead46c to 9c27f5c Compare November 4, 2023 16:32
@Brutus5000 Brutus5000 requested a review from Askaholic November 4, 2023 16:35
@Brutus5000 Brutus5000 marked this pull request as ready for review November 4, 2023 18:35
Comment on lines -830 to -831
"twilio": {
"hashes": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use pipenv to uninstall the package so that the lock file is updated correctly. Just deleting twilio from here is not correct because there are sub-dependencies that are no longer needed and there is also a meta section in the lockfile that contains a checksum that also needs to be updated.

You either need to run pipenv uninstall twilio which will remove twilio and its dependencies, but will also upgrade all other dependencies. This will be the easiest.

Or, run pipenv graph to figure out what twilios dependencies are:

twilio==8.10.0
  - aiohttp [required: >=3.8.4, installed: 3.8.6]
  - aiohttp-retry [required: >=2.8.3, installed: 2.8.3]
  - PyJWT [required: >=2.0.0,<3.0.0, installed: 2.8.0]
  - requests [required: >=2.0.0, installed: 2.31.0]

And then uninstall the ones that are not not required by twilio and are not otherwise listed in the Pipfile: pipenv uninstall --keep-outdated twilio aiohttp-retry requests. Even when I do this method it still seems to be upgrading charset-normalizer so I'd probably just go with method 1.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just decided to commit what I had since I checked out the branch anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. I'm not deep into the Python packaging.

@Askaholic Askaholic merged commit a0c19de into develop Nov 5, 2023
7 checks passed
@Askaholic Askaholic deleted the feature/remove-twilio branch November 5, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants