유저정보 입력UI #42
Merged
유저정보 입력UI #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- zod 설치 - InputFormItem 작성
추후 추가했을때 문제가 있을 수 있음
kichul7493
reviewed
Sep 3, 2024
| expect(screen.getByText('상세 주소')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('validates nickname field', async () => { |
There was a problem hiding this comment.
정상 입력의 경우도 테스트하면 좋지 않을까 생각됩니다.
| position?: 'static' | 'fixed' | 'absolute' | ||
| } | ||
|
|
||
| const Header = ({ left, center, right, position = 'static', ...props }: HeaderProps) => { |
There was a problem hiding this comment.
공용으로 사용할 수 있도록 만들어주셨군요👏👏👏
고생하셨습니다
| export type CreateMemberFormDataType = z.infer<typeof createMemberFormSchema> | ||
|
|
||
| // useSignupForm 훅 정의 | ||
| export const useSignUpForm = () => { |
There was a problem hiding this comment.
특별한 이유가 없다면 파일 이름과 Hook 이름이 통일되면 좋지 않을까 싶습니다.😊
jun0811
force-pushed
the
feature/#29-user-info
branch
from
bb4b580 to
61a0eaa
Compare
jun0811
force-pushed
the
feature/#29-user-info
branch
from
043105a to
854c614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
회원가입 정보 받는 폼입니다
FormItem 컴포넌트화 일단 간단하게 만들어뒀습니다
추후에 주소 검색 기능 붙일 예정입니다