Feat: 메뉴 상세 UI 작성 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkbox, label, radio-group 컴포넌트 추가
jun0811
reviewed
Sep 7, 2024
There was a problem hiding this comment.
src/components/shared/BackButton/index.tsx
여기에 예전에 제가 만들어 둔게 있어서 이걸 추가해서 하면 좋을 것 같습니다
기능적으로 부족하면 추가적으로 커스텀하셔도 되고여
There was a problem hiding this comment.
아까 질문드린대로 잘적용했습니다 확인 부탁드려요!
kichul7493
approved these changes
Sep 10, 2024
| </Label> | ||
| </div> | ||
| <div className="flex items-center space-x-2"> | ||
| <RadioGroupItem |
There was a problem hiding this comment.
반복 되는 컴포넌트를 분리하면 좋지 않을까요?
만약 수정해야 하면 전부 다 찾아다니면서 고쳐야 해서 힘들거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #31