Correct confusion of gamma's with gamma's_tra #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build error on macOS
Better helpful comments, plus a typo
Update gen_modules_rotate_grid.F90
- FESOM2.0 simulations on AWI ollie HPC were not always reproducible. Runs with identical namelists, init-conditions ... could lead to sligthly different results. - Natalja solved that issue by changing the compiler flag -fast-transcendentals with -fimf-use-svml - with this option loops with exp, sin, cos ... (IEEE function) will be always computed through the vector implementation otherwise the compiler is not fixed how IEEE funtions should be treated, which can be either Vector, Scalar or something else. All three can give slightly different results
…ly added in ice_therm when there is no cavity otherwise balancing might be corrupted
…t since under the cavity there is rigid lid approximation
Fix problem with FESOM2.0 reproducability bias on ollie
a compilation mistake for AWICM 2.0 was pointed out by Gregor
Update gen_forcing_couple.F90
…numerical reasons so that github testcase does not fail but with brackets would be most likely better. Add them add later point
- explicitly disable OpenMP compiling for the Cray ftn compiler
Workbench bugfix cavity
…o that freshwater balancing adds up
Merge latest awicm3 frontiers changes
… not in the file (i.e. the model should not stop but use the values with which the variable was initialised initially)
Fix bug when making restart with cavity from partial cell off --> partial cell on
@koldunovn you were right regarding the line splitting
Update tests
Actions are not triggered for whatever reason, try again.
set more recent compilers and mpi configuration to bsc environment
fix KPP bug discovered by Dima. Affects results, so tests are changed…
bug fix in update_atm_forcing. press_air array was accessed even if n…
gamma0, gamma1 & gamma2 were used instead gamma0_tra, gamma1_tra & gamma2_tra in diff_part_bh
gamma0, gamma1 & gamma2 were used instead gamma0_tra, gamma1_tra & gamma2_tra in diff_part_bh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug fix to correct the confusion of gamma0, gamma1, and gamma2 with gamma0_tra, gamma1_tra, and gamma2_tra should be put into the awicm-3-frontiers_parallel-restart branch.