Add identifiable Python include directory name for Python wrappers #3608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the python module installs the header files into the (include) path
python/dolfinx/wrappers
, which is then accessible throughdolfinx.get_include
.This however drops the necessity/option of a name giving include path for dolfinx extension modules. For example the
array.h
file of the dolfinx wrappers is then included in a third party lib as<array.h>
obscuring its origin. This can be for example seen in action in dolfinx_mpc and multiphenicsx .This PR introduces an additional sub directory
dolfinx_wrappers
for the installed headers, so the new include for the pyhton wrapper headers adds the descriptive additional prefix<dolfinx_wrappers/...>
.Also, removes file
python/dolfinx/wrappers/__init__.py
, which is superseded bypython/dolfinx/__init__.py::get_include
, and movespy_to_cpp_coeffs
into thedolfinx_wrappers
namespace (previously in global scope).