Revise warning message for configuration "pages" property #1318
Conversation
An unrecognized property within the "pages" property may or may not represent a subpage. Revise warning message to better acknowledge both possibilities.
src/import/importConfiguration.ts
Outdated
| let recommendation = `Check that ${ | ||
| singular ? 'this property is' : 'these properties are' | ||
| } spelled and indented correctly.`; |
There was a problem hiding this comment.
Based on the issue that brought this up, I'm wondering if this recommendation message should say "spelled, capitalized, and indented correctly"? It is definitely wordy and clunky, but I think if I had written Title how it is in the issue, I might still be confused because there are no typos there. But, I can be convinced this falls under spelling, so if you really don't like this, no worries.
There was a problem hiding this comment.
Alternatively, is there a reason we are case sensitive here?
There was a problem hiding this comment.
Properties in JS/TS are normally case-sensitive. I'm okay with sticking with case-sensitive properties for the configuration, so I'll add in a note about capitalization. We could potentially try to make configuration processing allow for arbitrary capitalization for the expected properties, but I think that would fall outside the scope of this PR.
Fixes #1308 and completes task CIMPL-1144.
An unrecognized property within the "pages" property may or may not represent a subpage. Revise warning message to better acknowledge both possibilities.