Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more error puns #1319

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Add more error puns #1319

merged 4 commits into from
Aug 4, 2023

Conversation

vadi2
Copy link
Contributor

@vadi2 vadi2 commented Aug 3, 2023

Very important community contribution.

@cmoesel
Copy link
Member

cmoesel commented Aug 3, 2023

Very important, indeed! I like these, @vadi2!

It looks like there's still an issue with code style. I think that when a string contains literal ', prettier prefers using " to surround the string so you don't have to escape the '. You should be able to fix it by running npm run prettier:fix.

@vadi2
Copy link
Contributor Author

vadi2 commented Aug 3, 2023

I have succeeded.

cmoesel
cmoesel approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, you have succeeded. Great puns too. Thanks!

@cmoesel cmoesel merged commit 6c4c9e8 into FHIR:master Aug 4, 2023
7 checks passed
@vadi2 vadi2 deleted the patch-1 branch August 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoesel cmoesel cmoesel approved these changes

@jafeltra jafeltra Awaiting requested review from jafeltra

@mint-thompson mint-thompson Awaiting requested review from mint-thompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadi2 @cmoesel