Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build command to antlr4 workaround script #1327

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add build command to antlr4 workaround script #1327

merged 2 commits into from
Aug 21, 2023

Conversation

mint-thompson
Copy link
Collaborator

The updated script in #1325 should have included the npm run build step that was removed from package.json.

jafeltra
jafeltra reviewed Aug 21, 2023
View reviewed changes
dev/fixAntlr4.js Outdated Show resolved Hide resolved
jafeltra
jafeltra approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the workaround works again!

@jafeltra jafeltra merged commit e102a52 into master Aug 21, 2023
14 checks passed
@jafeltra jafeltra deleted the even-more-better-antlr4-workaround branch August 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafeltra jafeltra jafeltra approved these changes

@cmoesel cmoesel Awaiting requested review from cmoesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mint-thompson @jafeltra