[summary] reslove performance problem of detach (#184)

Co-authored-by: ahxiao <[email protected]>
FISCO-BCOS · Oct 7, 2023 · 89a1247 · 89a1247
1 parent eabad8c
commit 89a1247
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/bindings/java/jni/src/main/c/jni/org_fisco_bcos_sdk_jni_rpc_RpcJniObj.cpp b/bindings/java/jni/src/main/c/jni/org_fisco_bcos_sdk_jni_rpc_RpcJniObj.cpp
@@ -24,7 +24,7 @@ static void on_receive_rpc_response(struct bcos_sdk_c_struct_response* resp)
     delete context;
 
     JNIEnv* env;
-    jvm->AttachCurrentThread((void**)&env, NULL);
+    jvm->AttachCurrentThreadAsDaemon((void**)&env, NULL);
 
     std::string className = "org/fisco/bcos/sdk/jni/common/Response";
     std::string onRespSig = "(Lorg/fisco/bcos/sdk/jni/common/Response;)V";
@@ -108,9 +108,6 @@ static void on_receive_rpc_response(struct bcos_sdk_c_struct_response* resp)
 
     // release callback global reference
     env->DeleteGlobalRef(jcallback);
-
-    // detach current thread when job finished
-    jvm->DetachCurrentThread();
 }
 
 /*

diff --git a/bindings/java/jni/src/main/c/jni/org_fisco_bcos_sdk_jni_rpc_RpcServiceJniObj.cpp b/bindings/java/jni/src/main/c/jni/org_fisco_bcos_sdk_jni_rpc_RpcServiceJniObj.cpp
@@ -25,7 +25,7 @@ static void on_receive_tars_rpc_response(struct bcos_sdk_c_struct_response* resp
     delete context;
 
     JNIEnv* env;
-    jvm->AttachCurrentThread((void**)&env, NULL);
+    jvm->AttachCurrentThreadAsDaemon((void**)&env, NULL);
 
     std::string className = "org/fisco/bcos/sdk/jni/common/Response";
     std::string onRespSig = "(Lorg/fisco/bcos/sdk/jni/common/Response;)V";
@@ -109,9 +109,6 @@ static void on_receive_tars_rpc_response(struct bcos_sdk_c_struct_response* resp
 
     // release callback global reference
     env->DeleteGlobalRef(jcallback);
-
-    // detach current thread when job finished
-    jvm->DetachCurrentThread();
 }
 
 /*