When disk signature invalid try the next LUN instead of giving up on the entire port #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ii-U-formatted drive, move onto the next LUN instead of giving up entirely. In addition, add GitHub CI and fill in the version number and timestamp in meta.xml.
…will have to commit loader.dol back.
…ew meta.xml. Have to maintain 2 copies for now, merging them is pretty difficult. Also, there has never been any mechanism for main.c to write the date to meta.xml, and this is what we will need to look into.
…nt date/time, which is passed by make as META_DATETIME. If that variable is missing the existing 2016 timestamp is used.
eku
reviewed
Mar 22, 2022
.github/workflows/main.yml
Outdated
| git config user.name '${GITHUB_ACTOR}' | ||
| git config user.email '${GITHUB_ACTOR}@users.noreply.github.com' | ||
| git add nintendont/loader.dol | ||
| git commit -m "loader.dol" |
There was a problem hiding this comment.
Shouldn't the version at least be written here?
There was a problem hiding this comment.
You mean, something like loader.dol v<major ver>.<build number>?
…number. Since MINOR_VERSION is reset, MAJOR_VERSION gets a bump to 7. Detect if FIX94 repository and if not, attach a NIN_SPECIAL_VERSION identifying the fork on the screen when loader is run.
…hat also is directly fetched by the online update feature. The GitHub CI workflow number is automatically inserted into that header with sed. Switch to oldest tag of devkitppc on docker hub. All compiler warnings go away now. Hopefully those warnings will be fixed for real some day with the latest compiler.
…ARM and devkitPPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #991. In addition, add GitHub CI and fill in the version number and timestamp in meta.xml. Please squash commits. Please visit https://gbatemp.net/threads/2-drive-enclosure.608112