Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assert that blocks Realm #622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove assert that blocks Realm #622

wants to merge 1 commit into from

Conversation

nathandud
Copy link

Proposed fix to #621. A realm database table opens as expected when this NSParameterAssert is removed.

@NSExceptional
Copy link
Collaborator

Can you see if just removing the && !databaseManager from the none condition part fixes it? I still want to keep the assertion, it just needs to be correct

@NSExceptional NSExceptional added the awaiting response … from the author, to proceed label Sep 26, 2022
@lubelio
Copy link

lubelio commented Dec 9, 2022

rowIDs:(nullable NSArray<NSString *> *)rowIDs

Can you see if just removing the && !databaseManager from the none condition part fixes it? I still want to keep the assertion, it just needs to be correct

It only works if removing rowIDs and !rowIDs from both all and none conditions

capecrawler pushed a commit to capecrawler/FLEX that referenced this pull request Jun 5, 2023
Fix crash on opening realm DB (FLEXTool#622)
61ff9e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting response … from the author, to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathandud @NSExceptional @lubelio