-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nested global entries #651
base: master
Are you sure you want to change the base?
Conversation
In Swift, if you don't use the closure argument, like this: FLEXManager.shared.registerGlobalEntry(withName: "Name") { _ in
print("Log")
} you now get the build error:
and the only workaround that I can think of is changing the call to: FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: UITableViewController) in
print("Log")
} or FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: FLEXUserGlobalEntriesContainer) in
print("Log")
} But this means that you have to look into FLEX's files to find this out, if you're new to it. So, I will rename the new method (from Swift's POV, the first parameter name), to avoid this ambiguity: FLEXManager.shared.registerNestedGlobalEntry(withName: "Name") { _ in
print("Log")
} |
@NSExceptional, do you have time to look over this? 😁 |
Not at the moment no; I was actually in a serious car accident on Tuesday and just got out of the hospital yesterday 🤕 I reviewed a PR yesterday but it was just a small bug fix |
I'll try to get to this when I can use my hand again |
OMG, I'm so sorry to hear that 😱 Forget about this PR, get well soon 🤗 |
544945a
to
5c4a218
Compare
Hey dawg! I'm finally getting around to clearing out all these PRs and issues that have accumulated over the last year. Sorry for the delay. I appreciate your patience (and frequent contributions). Still reviewing, but I'm curious, what's the use case for changing the cell accessory type? |
This is so we can remove the (now) superfluous methods that only forward the same parameters to the new container object.
5c4a218
to
94b6883
Compare
Please review each commit separately, as this PR is logically split into multiple "slow" transitions from the current implementation to the new one.