Improve version.php script (do not prompt for upgrade after running it) #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not accidentally bump the core version up - if we downgraded any plugins or core and moodle does not need upgrade, update the verison hash This way we won't need to run upgrade script after fixing version
|
Thanks Marina. Have you considered simply running: |
|
I run this script on non-mdk installations so it was convenient for me if it does everything out-of-the-box. But if you think it's not needed, ignore this pull request |
|
also my change to line 33 was a bug imho |
FMCorz
force-pushed
the
master
branch
4 times, most recently
from
87b93e4 to
0a1b6c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we won't need to run upgrade script after fixing version