Disregard case when sorting devrooms on schedule page #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version currently online displays "eBPF" at the end of the list of devrooms on the schedule page, because it starts with a lowercase, making it harder to find in the list. Instead, make devroom sorting case-insensitive. This is consistent with how the lists for the Stands, BoFs, and Junior events are generated on the same page.
|
I think this needs a different fix, but thanks for reporting it! |
|
Ah, sorry about that. For the report, you're most welcome 🙂 Should I turn this into an issue? |
|
I'm looking into it anyway. Perhaps your fix is okay, but then at least there is another issue as well :-) |
|
FYI, i did: b2bfaa2 |
|
The updated page looks great, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version currently online displays "eBPF" at the end of the list of devrooms on the chedule page, because it starts with a lowercase, making it harder to find in the list. Instead, make devroom sorting case-insensitive. This is consistent with how the lists for the Stands, BoFs, and Junior events are generated on the same page.