web scraping part #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial_scrape.py is the main file
|
@LasithaE. I guess the scraping part works. One suggestion I have is that to make the code a bit more readable as this is an open source Project. That is, It would be better if the variable names are a bit more meaningful. |
| d3["Type"] = b[2] | ||
|
|
||
| f7 = open( | ||
| "/Users/Lasitha/Documents/art_tweets/scraped_data/current_tweet.txt", "w+" |
There was a problem hiding this comment.
@LasithaE first of all, congrats on opening the PR! Two comments: next time onwards, please open PRs from a different branch. Also if you check link 179 (and other similar lines throughout), how do you plan to make sure the files exist on the user's PC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial_scrape.py is the main file