TNS-FRB crossmatching script #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TNS crossmatching script, now compatible with TNS 2.0 API querying.
profxj
requested changes
Feb 28, 2025
| return name, ra, dec, theta, a, b | ||
|
|
||
|
|
||
| def cov_matrix(a, b, theta): |
There was a problem hiding this comment.
these methods looks very useful!
might be better in another location..
There was a problem hiding this comment.
Could add them to utilities.py or something like that.
| #plt.savefig(f'{transient_name}_gaussian_map.png') | ||
|
|
||
|
|
||
| def main(filename, name, ra, dec, theta, a, b, radius, single_obj=False): |
There was a problem hiding this comment.
are we going to make this a proper script?
If so, we need to add another file.
There was a problem hiding this comment.
I would like to turn this into a proper script to be made available when the paper comes out. What other file is needed? I guess I don't know what that entails...
docstring descriptions of variables and what the functions do
I updated the script based on your suggestions! let me know if there's anything else to add. Thanks X! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated TNS crossmatching script, now compatible with TNS 2.0 API querying.