Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coast Mode Elevator Zeroing #245

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Coast Mode Elevator Zeroing #245

wants to merge 5 commits into from

Conversation

S0L0GUY
Copy link
Contributor

@S0L0GUY S0L0GUY commented Feb 4, 2025

This pull request includes several changes to the src/main/java/frc/robot directory to configure new motor settings and import necessary classes. The most important changes include the addition of a new configuration for the elevator motors and the initialization of these motors in the Robot class.

Motor Configuration and Initialization:

@S0L0GUY S0L0GUY added the 💻 Tested in sim Code has been tested in Robot Simulation label Feb 4, 2025
@S0L0GUY S0L0GUY requested a review from a team as a code owner February 4, 2025 22:42
@S0L0GUY S0L0GUY linked an issue Feb 4, 2025 that may be closed by this pull request
Copy link
Member

@TaylerUva TaylerUva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to do this is a similar way you did the manual zeroing. You are creating new talon fx which won't work. You'll need to reference elevator subsystem somehow

@S0L0GUY S0L0GUY added 🛑 Untested Code has not been tested and removed 💻 Tested in sim Code has been tested in Robot Simulation labels Feb 5, 2025
src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator.java Outdated Show resolved Hide resolved
Copy link
Member

@TaylerUva TaylerUva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lets test!

@@ -342,6 +342,11 @@ public Command checkForManualZeroing() {
.ignoringDisable(true);
}

public Command setElevatorCostMode(boolean coastMode) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can set how much the elevator costs???? (●'◡'●)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 Untested Code has not been tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coast Mode Zeroing
4 participants