-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pull request focused on integrating pre-commit and addressing several minor issues. #190
Conversation
…tdata api/plugin.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that all previously defined tests are running, and that we don't overuse types: ignore
declaration too much.
Dear @antarcticrainforest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests need some updates, especially the one that tests if a broken plugin marked itself as broken.
Could you also describe how to set up the pre-commit hooks in the README?
…e and remove if condition in docs service of ci_jobs
Dear @antarcticrainforest, I've found the issue affecting failure (freezed) of docs job in pipeline, which mirrors the same problem we encountered in a unit test where no status other than Identified Issues:
Solution: A straightforward fix to get the documentation building process working is to simply remove these two problematic However, for a more fundamental solution, we need to investigate why the res = freva.run_plugin("dummypluginfolders", batchmode=True) If you agree I will comment |
That is interesting. I do have a suspicion. I'll check tomorrow morning the docs config. Specifically what sheduler is used when the batchmode=True option gets involved. |
…ally fixing the hanging issue
thanks @antarcticrainforest after seven months finally we got the green pipeline in all services :). I think one of your review requests changrs is just stuck there and has blocked the Merging #190 (review) |
@antarcticrainforest btw one docs action to main branch is still running: https://github.com/FREVA-CLINT/freva/actions/runs/9061866502/job/24894525377 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cancelled. |
This PR introduces pre-commit integration and fixes a number of minor issues. Detailed updates are documented in the CHANGELOG.md.
ci_job
is green now