Create docker images #194
Merged
Create docker images #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @antarcticrainforest, this afternoon I go for reviewing and taking a test on CI of metadata-crawler |
mo-dkrz
reviewed
May 17, 2024
mo-dkrz
approved these changes
May 17, 2024
|
@antarcticrainforest btw i forgot to say, when u merged the PR, I would take a test on the metadata-crawler CI using the newest image ... |
|
Any more suggestions? |
|
all good imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 this PR simply adds the auto creation of the freva-dev (container with conda , MySQL and solr without freva pre-installed) and the freva container (samve as frva-dev but freva lib installed).
@MoSHad91 you can use these containers (once merged) in the gitlab-ci for the metadata-crawler and your plugin template.