Merge pull request #17885 from LabNConsulting/chopps/fix-gen-cb-regre…

…ssion tools: fix regression in gen_northbound_callback tool
FRRouting · Jan 20, 2025 · 42b10da · 42b10da
2 parents 084ebc9 + 2e0387c
commit 42b10da
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/tools/gen_northbound_callbacks.c b/tools/gen_northbound_callbacks.c
@@ -238,12 +238,10 @@ static int generate_prototypes(const struct lysc_node *snode, void *arg)
 		generate_callback_name(snode, cb->operation, cb_name,
 				       sizeof(cb_name));
 
-		if (cb->operation == NB_CB_GET_ELEM) {
-			if (f_new_cbs)
-				generate_prototype(&nb_oper_get, cb_name);
-			else
-				generate_prototype(cb, cb_name);
-		}
+		if (cb->operation == NB_CB_GET_ELEM && f_new_cbs)
+			generate_prototype(&nb_oper_get, cb_name);
+		else
+			generate_prototype(cb, cb_name);
 
 		if (cb->need_config_write && need_config_write) {
 			generate_config_write_cb_name(snode, cb_name,
@@ -344,12 +342,10 @@ static int generate_callbacks(const struct lysc_node *snode, void *arg)
 		generate_callback_name(snode, cb->operation, cb_name,
 				       sizeof(cb_name));
 
-		if (cb->operation == NB_CB_GET_ELEM) {
-			if (f_new_cbs)
-				generate_callback(&nb_oper_get, cb_name);
-			else
-				generate_callback(cb, cb_name);
-		}
+		if (cb->operation == NB_CB_GET_ELEM && f_new_cbs)
+			generate_callback(&nb_oper_get, cb_name);
+		else
+			generate_callback(cb, cb_name);
 
 		if (cb->need_config_write && need_config_write) {
 			generate_config_write_cb_name(snode, cb_name,