-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add igmp proxy support #16861
base: master
Are you sure you want to change the base?
Add igmp proxy support #16861
Conversation
fe1768e
to
7adb219
Compare
|
||
DEFUN (show_ip_igmp_proxy, | ||
show_ip_igmp_proxy_cmd, | ||
"show ip igmp [vrf NAME] proxy [json]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could easily be combined with show_ip_igmp_join_cmd since they both do the same thing, just passing a different type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Jafar about this and he prefers to leave them separate, both for clarity and also because the proxy command may expand in the future. If it does, we'll just have to pull them apart again.
} | ||
|
||
DEFUN (show_ip_igmp_proxy_vrf_all, | ||
show_ip_igmp_proxy_vrf_all_cmd, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, merge with the other show that does basically the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
pimd/pim_cmd.c
Outdated
interface_ip_igmp_proxy_cmd, | ||
"[no] ip igmp proxy", | ||
NO_STR | ||
IP_STR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
Use existing igmp static join infrastructure. Add an enum to distinguish static from proxy joins. Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
7adb219
to
ed5a913
Compare
ci:rerun Strange Ubuntu18 build failure? |
This PR adds the ability to proxy igmp joins received on downstream interfaces to one or more upstream interfaces