Add igmp proxy support #16861
Merged
Add igmp proxy support #16861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btrent98
force-pushed
the
igmp-proxy2
branch
4 times, most recently
from
fe1768e
to
7adb219
Compare
nabahr
reviewed
Sep 20, 2024
|
|
||
| DEFUN (show_ip_igmp_proxy, | ||
| show_ip_igmp_proxy_cmd, | ||
| "show ip igmp [vrf NAME] proxy [json]", |
There was a problem hiding this comment.
This could easily be combined with show_ip_igmp_join_cmd since they both do the same thing, just passing a different type.
There was a problem hiding this comment.
I talked to Jafar about this and he prefers to leave them separate, both for clarity and also because the proxy command may expand in the future. If it does, we'll just have to pull them apart again.
nabahr
reviewed
Sep 20, 2024
| } | ||
|
|
||
| DEFUN (show_ip_igmp_proxy_vrf_all, | ||
| show_ip_igmp_proxy_vrf_all_cmd, |
There was a problem hiding this comment.
Same, merge with the other show that does basically the same thing.
nabahr
reviewed
Sep 20, 2024
pimd/pim_cmd.c
Outdated
| interface_ip_igmp_proxy_cmd, | ||
| "[no] ip igmp proxy", | ||
| NO_STR | ||
| IP_STR |
added 2 commits
September 20, 2024 13:44
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
btrent98
force-pushed
the
igmp-proxy2
branch
from
7adb219
to
ed5a913
Compare
|
ci:rerun Strange Ubuntu18 build failure? |
donaldsharp
reviewed
Sep 22, 2024
pimd/pim_iface.c
Outdated
| @@ -1418,6 +1423,18 @@ int pim_if_gm_join_del(struct interface *ifp, pim_addr group_addr, | |||
| " group %pPAs source %pPAs on interface %s", | |||
| __func__, &group_addr, &source_addr, ifp->name); | |||
| return -3; | |||
| } else if (ij->join_type != join_type) { | |||
There was a problem hiding this comment.
Since we have if (!ij)… that always returns. Why do we need an elseif ? There is no need for it.
added 4 commits
September 23, 2024 11:43
Use existing igmp static join infrastructure. Add an enum to distinguish static from proxy joins. Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
Signed-off-by: Barry A. Trent <[email protected]>
btrent98
force-pushed
the
igmp-proxy2
branch
from
ed5a913
to
1425d4a
Compare
Jafaral
approved these changes
Sep 24, 2024
Jafaral
added a commit
that referenced
this pull request
Nov 12, 2024
New Features Highlight: - PIM candidate BSR/RP [#16438] - Static IGMP join without an IGMP report [1#6450] - PIM AutoRP discovery/announcements [#16634] - IGMP proxy [#16861] - SRv6 SID Manager [#15604] - Add `bgp ipv6-auto-ra` command [#16354] - Implement `neighbor x remote-as auto` for BGP [#16345] - Implement `bgp dual-as` for BGP [#16816] - Implement BGP-wide configuration for graceful restart [#16099] - Handle kernel routes appropriately (should fix recent NOPREFIXROUTE issue) [#16300] - Add `cisco-authentication` password support for NHRP [#16172] Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to proxy igmp joins received on downstream interfaces to one or more upstream interfaces