Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Revalidate locally originated routes also when RPKI state changes #16483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bgpd: Revalidate locally originated routes also when RPKI state changes #16483

wants to merge 3 commits into from

Commits on Sep 18, 2024

  1. bgpd: Revalidate locally originated routes also when RPKI state changes 

    If we have something like:

```
router bgp 65001
 network 10.10.10.0/24 route-map rpki
!
route-map rpki permit 10
 match rpki valid
 set local-preference 150
route-map rpki permit 20
 match rpki notfound
 set local-preference 50
!
```

Then 10.10.10.0/24 is never revalidated when RPKI state changes. E.g. if it was
valid, and moves to notfound => local-preference remains 150, but should be 50.

With this patch we force BGP network (static) routes to be revalidated when
revalidation event is triggered from RPKI module.

Signed-off-by: Donatas Abraitis <[email protected]>
    @ton31337
    ton31337 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    33a28c2 View commit details
    Browse the repository at this point in the history

  2. bgpd: Revalidate redistributed routes also when RPKI state changes 

    If we have something like:

```
router bgp 65001
 redistribute connected route-map rpki
!
route-map rpki permit 10
 match rpki valid
 set local-preference 150
route-map rpki permit 20
 match rpki notfound
 set local-preference 50
!
```

Then connected routes are never revalidated when RPKI state changes. E.g. if it was
valid, and moves to notfound => local-preference remains 150, but should be 50.

With this patch we force redistributed routes to be revalidated when
revalidation event is triggered from RPKI module.

Signed-off-by: Donatas Abraitis <[email protected]>
    @ton31337
    ton31337 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7ff082e View commit details
    Browse the repository at this point in the history

  3. bgpd: Revalidate all routes periodically using a separate event 

    Signed-off-by: Donatas Abraitis <[email protected]>
    @ton31337
    ton31337 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    77476b6 View commit details
    Browse the repository at this point in the history