nhrpd: Implement retrying resolution request #16788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuthiilabn
force-pushed
the
jmuthii/nhrpd-retry-resolution
branch
3 times, most recently
from
26cf094
to
32b1af6
Compare
aceelindem
approved these changes
Sep 11, 2024
nhrpd/nhrp_shortcut.c
Outdated
| * received for a "request" and a retry is sent after an | ||
| * appropriate interval | ||
| */ | ||
| if (!retry) { |
There was a problem hiding this comment.
Although not completely consistent, FRR style normally omits the braces when there is a single conditional statement.
ton31337
reviewed
Sep 13, 2024
| event_add_timer(master, nhrp_shortcut_retry_resolution_req, s, | ||
| s->retry_interval, &s->t_retry_resolution); | ||
| if (s->retry_interval != (NHRPD_DEFAULT_PURGE_TIME / 4)) | ||
| s->retry_interval = ((s->retry_interval * 2) < |
There was a problem hiding this comment.
Is this something we should add, or at least a comment on, about what's going on here and why it's calculated this way?
There was a problem hiding this comment.
Yes, I'll add a comment explaining the interval calculation.
|
@jmuthiilabn , can you address the comments please ? |
jmuthiilabn
force-pushed
the
jmuthii/nhrpd-retry-resolution
branch
from
32b1af6
to
949feea
Compare
In the event that a resolution request is sent and and resolution reply is never received, resolution requests will continue to be sent until either the newly created shortcut has been purged or a resolution reply is finally received. NHRPD_DEFAULT_PURGE_TIME and NHRPD_PURGE_EXPIRE are values that were previously hardcoded and moved into macros for the sake of readability. Signed-off-by: Joshua Muthii <[email protected]>
jmuthiilabn
force-pushed
the
jmuthii/nhrpd-retry-resolution
branch
from
949feea
to
97a0368
Compare
|
@ton31337 - Donatas, are you good with the updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a resolution request is sent and and resolution reply is never received, resolution requests will continue to be sent until either the newly created shortcut has been purged or a resolution reply is finally received.
NHRPD_DEFAULT_PURGE_TIME and NHRPD_PURGE_EXPIRE are values that were previously hardcoded and moved into macros for the sake of readability.