Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: define val in ecommunity_val as uint8_t #16848

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

enkechen-panw
Copy link
Contributor

The type of the val field in ecommunity_val is used inconsistently in a number of places. It should be defined as uint8_t.

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the styling (frrbot / clang-formatter).

The type of the val field in ecommunity_val is used inconsistently
in a number of places. It should be defined as uint8_t.

Signed-off-by: Enke Chen <[email protected]>
@enkechen-panw
Copy link
Contributor Author

Done. Thanks

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 merged commit cc7d3af into FRRouting:master Sep 19, 2024
11 checks passed
@enkechen-panw enkechen-panw deleted the ecomm-val branch September 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants