Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: fix snytax of some no commands #16853

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Shbinging
Copy link
Contributor

@Shbinging Shbinging commented Sep 18, 2024

  1. Fixed the syntax of no ip ospf dead-interval minimal hello-multiplier to allow the parameter(2-20) to either present or absent, aligning with no ip ospf dead-interval command.
  2. Fixed the syntax of 'no ospf abr-type' same as above

@Shbinging
Copy link
Contributor Author

Please rerun the failed tests, as they should not be related to my changes.

@Shbinging Shbinging changed the title ospfd: fix no ip ospf dead-interval minimal hello-multiplier syntax ospfd: fix sytax of some no commands Sep 20, 2024
@Shbinging Shbinging changed the title ospfd: fix sytax of some no commands ospfd: fix snytax of some no commands Sep 20, 2024
@Shbinging Shbinging force-pushed the no_ip_ospf_dead_interval_minimal branch from b9b7384 to d2c59d6 Compare September 20, 2024 07:06
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@aceelindem aceelindem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e17a983 into FRRouting:master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants