zebra: Don't bind netns ID netlink socket to mcast groups #16854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The netlink socket in `zebra_ns_id_get()` is only used to get netns id.
There's no need to subscribe to multicast groups. In some heavy-loaded
cases, unexpected notification races with normal reply message and
causes failure:
zebra[110338]: [NMNEE-JJKPF][EC 4043309094] netlink recvmsg: bad sequence number 505ac8 (expected 66ea845f)
BTW, to subscribe to RTNLGRP_NSID, `nl_groups` should be
`1 << (RTNLGRP_NSID - 1)`. This code has never worked as expected.
Signed-off-by: Xiao Liang <[email protected]>
|
@pguibert6WIND please take a look at this and decide if this is right or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netlink socket in
zebra_ns_id_get()is only used to get netns id. There's no need to subscribe to multicast groups. In some heavy-loaded cases, unexpected notification races with normal reply message and causes failure:BTW, to subscribe to RTNLGRP_NSID,
nl_groupsshould be1 << (RTNLGRP_NSID - 1). This code has never worked as expected.