-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd:support tcp-mss for neighbor group #17341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A topology test for this case is a must.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting on comments and topo
22ad541
to
434a608
Compare
Done. Please help review again, thanks |
434a608
to
b4dd73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also apply black formatting for tests/topotests/bgp_tcp_mss/test_bgp_tcp_mss.py. And also, the test is still failing.
Signed-off-by: hanyu.zly <[email protected]>
b4dd73f
to
9fa56a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
bgpd:support tcp-mss for neighbor group (backport #17341)
support tcp-mss for neighbor group