Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd:support tcp-mss for neighbor group #17341

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

zice312963205
Copy link
Contributor

support tcp-mss for neighbor group

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A topology test for this case is a must.

bgpd/bgpd.c Outdated Show resolved Hide resolved
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on comments and topo

@zice312963205
Copy link
Contributor Author

A topology test for this case is a must.

Done. Please help review again, thanks

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also apply black formatting for tests/topotests/bgp_tcp_mss/test_bgp_tcp_mss.py. And also, the test is still failing.

bgpd/bgpd.c Outdated Show resolved Hide resolved
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 added this to the 10.2 milestone Nov 7, 2024
@ton31337
Copy link
Member

ton31337 commented Nov 7, 2024

@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

Copy link

mergify bot commented Nov 7, 2024

backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants