Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: clarify bgp_vpnv4_asbr #17368

Merged
merged 1 commit into from
Nov 12, 2024
Merged

tests: clarify bgp_vpnv4_asbr #17368

merged 1 commit into from
Nov 12, 2024
+151 −114

Conversation

louis-6wind
Copy link
Contributor

Clarify bgp_vpnv4_asbr. Cosmetic change.

@louis-6wind
tests: clarify bgp_vpnv4_asbr
aceae79 
Clarify bgp_vpnv4_asbr. Cosmetic change.

Signed-off-by: Louis Scalbert <[email protected]>
@frrbot frrbot bot added the tests Topotests, make check, etc label Nov 6, 2024
ton31337
ton31337 reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we drop \n everywhere from vtysh_cmd()?

riw777
riw777 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than @ton31337 's comment ...

@riw777 riw777 merged commit d1d8aee into FRRouting:master Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-6wind @riw777 @ton31337