Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topotests: bgp_evpn_rt5, add test with match evpn vni command #17652

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

topotests: bgp_evpn_rt5, add test with match evpn vni command #17652

wants to merge 5 commits into from

Conversation

pguibert6WIND
Copy link
Member

Add a test that ensures that the 'match evpn vni' command works with bgp evpn rt5 updates.

ton31337
ton31337 reviewed Dec 17, 2024
View reviewed changes
tests/topotests/bgp_evpn_rt5/r3/zebra.conf Outdated
@@ -0,0 +1,23 @@
log stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/topotests/bgp_evpn_rt5/r3/zebra.conf Outdated
@@ -0,0 +1,23 @@
log stdout

hostname r3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/topotests/bgp_evpn_rt5/r3/zebra.conf Outdated
log stdout

hostname r3
password zebra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/topotests/bgp_evpn_rt5/r3/zebra.conf Outdated
! debug zebra kernel
! debug zebra dplane
! debug zebra rib
log stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Jafaral
Jafaral requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Jafaral Jafaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use unified config, frr.conf

@pguibert6WIND
Copy link
Member Author

pguibert6WIND commented Dec 18, 2024 •
edited
Loading

Please use unified config, frr.conf

This is not as simple, but let s try. With unified config, test does not pass. Without unified config, test passes.
What is observed is that ipv4 routes from r1-vrf-101 are not exported as l2vpn evpn entries, when it does not work.

@pguibert6WIND pguibert6WIND force-pushed the topotest_bgp_evpn_rt5 branch 3 times, most recently from 395eab3 to 5176098 Compare December 20, 2024 14:07
@pguibert6WIND pguibert6WIND force-pushed the topotest_bgp_evpn_rt5 branch from 9f7b3a2 to 3ad2665 Compare January 2, 2025 10:03
@ton31337
Copy link
Member

ton31337 commented Jan 2, 2025

Can we fix frrbot issues?

@pguibert6WIND pguibert6WIND force-pushed the topotest_bgp_evpn_rt5 branch from 3ad2665 to a9b554f Compare January 2, 2025 15:20
@pguibert6WIND
Copy link
Member Author

Can we fix frrbot issues?

it should be ok now

@pguibert6WIND
Copy link
Member Author

ci:rerun unrelated

ton31337
ton31337 reviewed Jan 3, 2025
View reviewed changes
tests/topotests/bgp_evpn_rt5/r1/frr.conf Outdated
@@ -1,15 +1,42 @@
log stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

tests/topotests/bgp_evpn_rt5/r1/frr.conf Outdated
! debug bgp neighbor-events
! debug bgp updates
! debug bgp zebra
log stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

tests/topotests/bgp_evpn_rt5/r2/frr.conf Outdated
@@ -1,6 +1,24 @@
log stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

tests/topotests/bgp_evpn_rt5/r2/frr.conf Outdated
log stdout

hostname r2
password zebra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pguibert6WIND
topotests: bgp_evpn_rt5, add test with match evpn vni command
98a84ea 
Add a test that ensures that the 'match evpn vni' command works with bgp
evpn rt5 updates.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
topotests: bgp_evpn_rt5, configure route_distinguisher
0738134 
When not configuring a route distinguisher, neither route-target,
the derived rd settings differ if config load applies with frr.conf
or not. For instance, the forged rd with frr.conf:

> # show bgp l2vpn evpn json
>    "192.168.101.41:3":{
>       "rd":"192.168.101.41:3",

and without:
>     "192.168.101.41:2":{
>        "rd":"192.168.101.41:2",

The defined rts also are impacted. Temporay fix this by using an
hardset configuration for all route distinguisher and route target
of the setups.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
topotests: add unified configuration
0cc414a 
Replace the various per-daemon config files with a unique frr.conf
configuration file.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
bgpd: fix duplicate BGP instance created with unified config
c7799e4 
When running the bgp_evpn_rt5 setup with unified config, memory leak
about a non deleted BGP instance happens.

> root@ubuntu2204hwe:~/frr/tests/topotests/bgp_evpn_rt5# cat /tmp/topotests/bgp_evpn_rt5.test_bgp_evpn/r1.asan.bgpd.1164105
>
> =================================================================
> ==1164105==ERROR: LeakSanitizer: detected memory leaks
>
> Indirect leak of 12496 byte(s) in 1 object(s) allocated from:
>     #0 0x7f358eeb4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
>     FRRouting#1 0x7f358e877233 in qcalloc lib/memory.c:106
>     FRRouting#2 0x55d06c95680a in bgp_create bgpd/bgpd.c:3405
>     FRRouting#3 0x55d06c95a7b3 in bgp_get bgpd/bgpd.c:3805
>     FRRouting#4 0x55d06c87a9b5 in bgp_get_vty bgpd/bgp_vty.c:603
>     FRRouting#5 0x55d06c68dc71 in bgp_evpn_local_l3vni_add bgpd/bgp_evpn.c:7032
>     FRRouting#6 0x55d06c92989b in bgp_zebra_process_local_l3vni bgpd/bgp_zebra.c:3204
>     FRRouting#7 0x7f358e9e3feb in zclient_read lib/zclient.c:4626
>     FRRouting#8 0x7f358e98082d in event_call lib/event.c:1996
>     FRRouting#9 0x7f358e848931 in frr_run lib/libfrr.c:1232
>     FRRouting#10 0x55d06c60eae1 in main bgpd/bgp_main.c:557
>     FRRouting#11 0x7f358e229d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Actually, a BGP VRF Instance is created in auto mode when creating the
global BGP instance for the L3 VNI. And again, an other BGP VRF instance
is created. Fix this by ensuring that a non existing BGP instance is not
present. If it is present, and with auto mode or in hidden mode, then
override the AS value.

Fixes: f153b9a ("bgpd: Ignore auto created VRF BGP instances")

Signed-off-by: Philippe Guibert <[email protected]>

fixup bgpd: fix duplicate BGP instance created with unified config
@pguibert6WIND
bgpd: fix bgp evpn memory leaks when adj-rib-in is disabled
6ef780c 
Some bgp evpn memory contexts are not freed at the end of the bgp
process.

> =================================================================
> ==1208677==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 96 byte(s) in 2 object(s) allocated from:
>     #0 0x7f93ad4b4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
>     FRRouting#1 0x7f93ace77233 in qcalloc lib/memory.c:106
>     FRRouting#2 0x563bb68f4df1 in process_type5_route bgpd/bgp_evpn.c:5084
>     FRRouting#3 0x563bb68fb663 in bgp_nlri_parse_evpn bgpd/bgp_evpn.c:6302
>     FRRouting#4 0x563bb69ea2a9 in bgp_nlri_parse bgpd/bgp_packet.c:347
>     FRRouting#5 0x563bb69f7716 in bgp_update_receive bgpd/bgp_packet.c:2482
>     FRRouting#6 0x563bb6a04d3b in bgp_process_packet bgpd/bgp_packet.c:4091
>     FRRouting#7 0x7f93acf8082d in event_call lib/event.c:1996
>     FRRouting#8 0x7f93ace48931 in frr_run lib/libfrr.c:1232
>     FRRouting#9 0x563bb6880ae1 in main bgpd/bgp_main.c:557
>     FRRouting#10 0x7f93ac829d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Actually, the bgp evpn context may noy be used if adj rib in is unused.
This may lead to memory leaks. Fix this by freeing the context in those
corner cases.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND pguibert6WIND force-pushed the topotest_bgp_evpn_rt5 branch from a9b554f to 6ef780c Compare January 3, 2025 15:58
@pguibert6WIND
Copy link
Member Author

ci:rerun unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

@Jafaral Jafaral Jafaral requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bgp bugfix master size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pguibert6WIND @ton31337 @Jafaral