Fix restricted open for constructors of type with indices #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the following type: ```fstar type foo (foo_type_arg1: nat): foo_type_arg2:nat -> Type = | FooConstructor : foo_cons_arg1:nat -> foo foo_type_arg1 12 ``` Function `find_binders_for_datacons` exporting `foo_type_arg1`, `foo_type_arg2` and `foo_cons_arg1` as binders for the data constructor `FooConstructor`. This is wrong: the first two are indicies of the type. This commit fixes this function, using the field `num_ty_params` from the constructor `Sig_datacon`.
W95Psp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following type:
Function
find_binders_for_dataconsexportingfoo_type_arg1,foo_type_arg2andfoo_cons_arg1as binders for the data constructorFooConstructor. This was wrong: the first two are indices of the type.This commit fixes this function, using the field
num_ty_paramsfrom the constructorSig_datacon.This PR fixes #3522.