Tactics: fix V1.Logic #3584
Merged
Tactics: fix V1.Logic #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2 was reworked to have an interface and point to some lemmas in a separate module to reduce bloat in callers. The same thing was done for V1.Logic, but the internal lemmas remained and this caused calls to these tactics to fail (unless the fst happened to be loaded, which is usually not the case). Simply removing the internal private lemmas fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 was reworked to have an interface and point to some lemmas in a separate module to reduce bloat in callers. The same thing was done for V1.Logic, but the internal lemmas remained and this caused calls to these tactics to fail (unless the fst happened to be loaded, which is usually not the case).
Simply removing the internal private lemmas fixes this.