lib: Makefile: FStar.IO.fst is now FStar.IO.fsti #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of FStarLang/FStar#3549, which makes FStar.IO an interface which is conceptually more correct. I don't think this would have many users at the C level and would maybe just remove it from this list... but it is exposed, and has an implementation in krmllib/dist/generic/fstar_io.c. This is motivated by the new F* build, I'm trying to get some smaller pieces in independent PRs.
mtzguido
added a commit
to mtzguido/FStar
that referenced
this pull request
Oct 10, 2024
Same logic as for FStar.All, though this one needs a patch to the karamel build (FStarLang/karamel#490).
mtzguido
added a commit
to mtzguido/FStar
that referenced
this pull request
Oct 10, 2024
Same logic as for FStar.All, though this one needs a patch to the karamel build (FStarLang/karamel#490).
|
Probably a remnant of miTLS, if I had to venture a guess. Now that we no longer support C extraction of miTLS, we could also remove it. Up to you. |
|
Feel free to go ahead and merge this in whatever sequence works best for you. Thanks!! |
|
Cool, thanks! I'll leave it here for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of
FStarLang/FStar#3549FStarLang/FStar#3552, which makes FStar.IO an interface which is conceptually more correct.I don't think this would have many users at the C level and would maybe just remove it from this list... but it is exposed, and has an implementation in krmllib/dist/generic/fstar_io.c.
This is motivated by the new F* build, I'm trying to get some smaller pieces in independent PRs.
Btw I read this comment:
karamel/krmllib/Makefile
Lines 50 to 55 in 8c36120
I'm not sure I understand it but F* can now be queried for exactly that by
fstar.exe --locate_lib.