Makefile: improve confusing errors in inclusion #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've on occasion needed this to debug some visitors-related stuff, so if there's an easy to make it work out, I'm all for it, otherwise don't waste time! Thanks. |
|
Ah sounds good, let me update the PR with the robust check then. |
|
Done |
mtzguido
changed the title
This line gives some bad errors whenever ocamlfind is not in the PATH or the visitors package is not installed, and may carry on with the Makefile regardless of that failure (attempting to include /Makefile.preprocess along the way). $ make make: ocamlfind: No such file or directory Makefile:2: /Makefile.preprocess: No such file or directory make: *** No rule to make target '/Makefile.preprocess'. Stop. This patch makes the Makefile provide more helpful errors in both these situations: $ make make: ocamlfind: No such file or directory Makefile:7: *** "'ocamlfind query' failed, please install OCaml and put it in your PATH. Stop. $ make ocamlfind: Package `visitors' not found Makefile:11: *** "'ocamlfind query visitors' failed, please 'opam install visitors'. Stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line gives some bad errors whenever ocamlfind is not in the
PATH or the visitors package is not installed, and may carry on
with the Makefile regardless of that failure (attempting to include
/Makefile.preprocess along the way).
This patch makes the Makefile provide more helpful errors in both these
situations: