Correctly extract inner ghost functions. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
force-pushed
the
gebner_extract_inner_ghost
branch
from
ce78261
to
551a923
Compare
|
This is a repeat of #182. Guido added a test case there, but that test didn't catch this. The slices code used to break pulse2rust and serves as another test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inner ghost functions used to be extracted as
Obj.magic (fun _ -> ())(that's the definition, not the call site). Changing the let to have a pure effect allows extraction to remove the definition and the associated magic (which in turn breaks pulse2rust).More generally, I'm not sure if we need to put a DIV-effect on let-bindings with a C_Tot effect at all.