Merge pull request #56 from FTBTeam/1.19/dev

1.19/dev

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1902.3.5]
+
+### Fixed
+
+* Fixed an event handler running on the client side which shouldn't have been
+  * Led to undesirable effects like players flying when they shouldn't
+
 ## [1902.3.4]
 
 ### Fixed

common/src/main/java/dev/ftb/mods/ftbessentials/FTBEEventHandler.java

@@ -119,21 +119,23 @@ private static void playerLoggedOut(ServerPlayer serverPlayer) {
 	}
 
 	private static void playerTickPost(Player player) {
-		var data = FTBEPlayerData.get(player);
-		var abilities = player.getAbilities();
+		if (!player.level.isClientSide) {
+			var data = FTBEPlayerData.get(player);
+			var abilities = player.getAbilities();
 
-		if (data == null) {
-			return;
-		}
+			if (data == null) {
+				return;
+			}
 
-		if (data.god && !abilities.invulnerable) {
-			abilities.invulnerable = true;
-			player.onUpdateAbilities();
-		}
+			if (data.god && !abilities.invulnerable) {
+				abilities.invulnerable = true;
+				player.onUpdateAbilities();
+			}
 
-		if (data.fly && !abilities.mayfly) {
-			abilities.mayfly = true;
-			player.onUpdateAbilities();
+			if (data.fly && !abilities.mayfly) {
+				abilities.mayfly = true;
+				player.onUpdateAbilities();
+			}
 		}
 	}
 

gradle.properties

@@ -5,7 +5,7 @@ mod_id=ftbessentials
 archives_base_name=ftb-essentials
 maven_group=dev.ftb.mods
 minecraft_version=1.19.2
-mod_version=1902.3.4
+mod_version=1902.3.5
 mod_author=FTB Team
 
 ftb_library_version=1902.4.1-build.236