Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debug builds with old ninja versions #478

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

FreeSlave
Copy link
Member

${CMAKE_STRIP} is evaluated to empty string, so it tries to execute "" -s /path/to/cl_dll/client.so which leads to the error /bin/sh: 1: : Permission denied.

This behavior is observed with Ninja version installed in the Steam runtime container. Somehow it's not an issue on the newer versions.

The solution is to strip only on Release build in the postbuild.

@nekonomicon nekonomicon merged commit 5417e6c into FWGS:master Oct 24, 2024
4 checks passed
@FreeSlave FreeSlave deleted the fix-ninja-build branch October 24, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants