Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depreciation #84

Merged
merged 18 commits into from
Aug 9, 2024
Merged

Fix depreciation #84

merged 18 commits into from
Aug 9, 2024

Conversation

l-kotzur
Copy link
Collaborator

@l-kotzur l-kotzur commented Aug 9, 2024

@jo-omoyele @julian-belina

Heyho, it was a small fix and the depreciation warnings should no longer appear. Could you please approve it? I will publish it on PyPI.

Greetings to the world's best energy systems analysis department :P

@l-kotzur l-kotzur requested a review from jo-omoyele August 9, 2024 09:04
@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

A damn. It see the challenge.

@julian-belina
Copy link
Collaborator

julian-belina commented Aug 9, 2024

@l-kotzur you can also adjust the testpipeline. Not each version of tsam has to be compatible with all dependency versions. This just has to be reflected in the dependency constraints.

@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

Hey, I just took back the fixing of @jo-omoyele ignoring the warning, since the tests worked with future_stack=True. Therefore, future pandas version wont destroy the code.

@l-kotzur l-kotzur requested a review from julian-belina August 9, 2024 09:56
@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

@julian-belina I preferred your approach and modified also the required python version for PyPI.

@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

@julian-belina Can you approve?

@julian-belina
Copy link
Collaborator

julian-belina commented Aug 9, 2024

@l-kotzur I, will approve the merge once all tests suceeded. Do you need the new version asap? Otherwise I would like to implement some checks for different numpy versions.

@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

Appreciated! Take your time.

@julian-belina
Copy link
Collaborator

@l-kotzur, if you got some spare time could you delete some of the stale branches on this repository? Some of them are very old but I dont want to delte anything that might be used by someone.

@julian-belina
Copy link
Collaborator

@l-kotzur, also i increased the lower numpy limit by quite a bit based on the python compatability that is posted here:
https://endoflife.date/numpy

@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

@l-kotzur, if you got some spare time could you delete some of the stale branches on this repository? Some of them are very old but I dont want to delte anything that might be used by someone.

I did! Thanks for pointing out.

Copy link
Collaborator

@julian-belina julian-belina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@julian-belina
Copy link
Collaborator

@l-kotzur any last thoughts? Otherwise I think its ready to merge. Do you create the release and publish to pypi?

Greetings to the best of offspring of the institute :)

@l-kotzur l-kotzur merged commit 12713df into master Aug 9, 2024
98 checks passed
@l-kotzur
Copy link
Collaborator Author

l-kotzur commented Aug 9, 2024

Thanks a lot for pushing this topic and also maintaining the packages! I will make the releases. It was already due since some month.

@julian-belina julian-belina deleted the fix_depreciation branch August 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants