-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix depreciation #84
Fix depreciation #84
Conversation
Small improvements to timeseriesaggregation
A damn. It see the challenge. |
@l-kotzur you can also adjust the testpipeline. Not each version of tsam has to be compatible with all dependency versions. This just has to be reflected in the dependency constraints. |
…th old and new stack version
… into fix_depreciation
Hey, I just took back the fixing of @jo-omoyele ignoring the warning, since the tests worked with future_stack=True. Therefore, future pandas version wont destroy the code. |
@julian-belina I preferred your approach and modified also the required python version for PyPI. |
@julian-belina Can you approve? |
@l-kotzur I, will approve the merge once all tests suceeded. Do you need the new version asap? Otherwise I would like to implement some checks for different numpy versions. |
…t numpy version, add conda forge badge
Appreciated! Take your time. |
@l-kotzur, if you got some spare time could you delete some of the stale branches on this repository? Some of them are very old but I dont want to delte anything that might be used by someone. |
@l-kotzur, also i increased the lower numpy limit by quite a bit based on the python compatability that is posted here: |
I did! Thanks for pointing out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@l-kotzur any last thoughts? Otherwise I think its ready to merge. Do you create the release and publish to pypi? Greetings to the best of offspring of the institute :) |
Thanks a lot for pushing this topic and also maintaining the packages! I will make the releases. It was already due since some month. |
@jo-omoyele @julian-belina
Heyho, it was a small fix and the depreciation warnings should no longer appear. Could you please approve it? I will publish it on PyPI.
Greetings to the world's best energy systems analysis department :P