Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Descriptors.ytag #35

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add Descriptors.ytag #35

wants to merge 6 commits into from

Conversation

OverlordsIII
Copy link
Contributor

Adds descriptors.ytag as an alias for signatures.ytag because I keep mixing them up all the time

nnym
nnym approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@nnym nnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"descriptor" is the correct name. Perhaps signatures.ytag and descriptors.ytag ought to also swap names.

@i509VCB
Copy link
Contributor

i509VCB commented Jan 17, 2021

I think this should explain the proper term in each tag - maybe mentioning the other tag as a disambiguation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnym nnym nnym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OverlordsIII @i509VCB @nnym