Recursive codecs name change #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
approved these changes
Jul 5, 2024
|
Seems like Mojang updated DFU separately from Minecraft (we've seen them do this with the likes of authlib and brigadier), which is why this wasn't originally caught as an issue. Thanks. |
JR1811
pushed a commit
to JR1811/fabric-docs
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecs#createRecursivedoes not exist anymore, and has been replaced withCodec#recurisve. Not sure when this change exactly occurred on the Minecraft Codebase, however I have updated the docs to reflect this.All instances of
Codecs#createRecursivehave been replaced withCodec#recurisve, along with instances in any code examples. The usage of these functions is the same, so no extra changes were required. Additionally, I made sure not to update any 1.20.4 articles, as this was probably correct at the time.