Add a guide for Custom Enchantments #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krizh-p
changed the title
IMB11
added
new-content
IMB11
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Quite a bit to do, but it's a great start - the structure is definitely there, it just needs the following done:
- Breaking up larger paragraphs into seperate paragraphs (especially the start and the "Creating The Enchantment" first paragraph.
- Delegating the datagen setup information to the relevant Fabric Wiki page
- Fix issues with markdown-lint, see either the files tab on this PR to see the issues, or view the github action logs, you can also use the vscode plugin to find all lint issues.
- Moving code from code blocks into the reference mod.
- Using either an LLM or a tool such as LanguageTool to ensure grammar and readability is good.
Overall, this is a great guide, it really uses all the features of the wiki, and will be really useful for many developers! Good job! 👍
reference/latest/src/main/java/com/example/docs/FabricDocsReference.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/data/EnchantmentGenerator.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/data/EnchantmentGenerator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Calum H. <[email protected]>
Co-authored-by: Calum H. <[email protected]>
Co-authored-by: Calum H. <[email protected]>
…c-docs into customEnchantments
|
Just went through and fixed everything mentioned in the code review |
its-miroma
requested changes
Jul 11, 2024
its-miroma
requested changes
Jul 12, 2024
applied suggested grammar fixes Co-authored-by: Miroma <[email protected]>
its-miroma
requested changes
Jul 18, 2024
JR1811
reviewed
Jul 20, 2024
...nce/latest/src/main/java/com/example/docs/enchantment/effect/LightningEnchantmentEffect.java
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/enchantment/ModEnchantmentEffects.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/data/EnchantmentGenerator.java
Show resolved
Hide resolved
|
I have cleaned up the introduction and final sentences, this is good IMO. |
its-miroma
requested changes
Aug 8, 2024
its-miroma
added
stage:verification
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
Co-authored-by: Miroma <[email protected]>
IMB11
added
stage:verification
its-miroma
requested changes
Dec 27, 2024
its-miroma
approved these changes
Dec 27, 2024
its-miroma
added
stage:ready
IMB11
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a guide for creating Custom Enchantment Effects as 1.21 completetly changes how enchantments must be made.