Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotswapping with JBR #137

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Hotswapping with JBR #137

merged 5 commits into from
Jul 11, 2024

Conversation

Tenneb22
Copy link
Contributor

Adds the method of hotswapping with DCVEM or JBR in english and german.

Adds the method of using the DCVEM or JetBrains JDK to Hotswap classes and methods.
Add the method of using the DCVEM or JetBrain Runtime JDK for hotswapping classes and methods in german.
@Tenneb22 Tenneb22 requested a review from a team as a code owner July 11, 2024 05:56
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 01e89bb
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/668fe33bd8bc5f0008a87b47
😎 Deploy Preview https://deploy-preview-137--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but you don't need to mention pre java 11 here, as the page is for 1.21 which uses Java 21

@IMB11
Copy link
Member

IMB11 commented Jul 11, 2024

Fix lint issues please.

@Tenneb22 Tenneb22 closed this Jul 11, 2024
@Tenneb22 Tenneb22 deleted the patch-1 branch July 11, 2024 12:47
@Tenneb22 Tenneb22 restored the patch-1 branch July 11, 2024 12:48
@Tenneb22 Tenneb22 reopened this Jul 11, 2024
@Tenneb22 Tenneb22 changed the title Hotswapping with DCVEM or JBR Hotswapping with JBR Jul 11, 2024
Co-authored-by: Miroma <[email protected]>
@its-miroma its-miroma added improvement A new addition to an already existing page stage:ready This is ready to be merged labels Jul 11, 2024
@Tenneb22 Tenneb22 requested a review from IMB11 July 11, 2024 13:30
@IMB11 IMB11 merged commit 00faaf0 into FabricMC:main Jul 11, 2024
7 checks passed
JR1811 pushed a commit to JR1811/fabric-docs that referenced this pull request Jul 17, 2024
* Add Hotswapping with a JDK

Adds the method of using the DCVEM or JetBrains JDK to Hotswap classes and methods.

* Add Hotswapping with a JDK

Add the method of using the DCVEM or JetBrain Runtime JDK for hotswapping classes and methods in german.

* Fixed lint issues and updated documentation

* Updated grammar

Co-authored-by: Miroma <[email protected]>

---------

Co-authored-by: Miroma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A new addition to an already existing page stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants