Skip to content

Implement locating pre-classic versions of Minecraft #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpaceWalkerRS
Copy link
Contributor

In pre-classic versions the com/mojang/rubydung/RubyDung class contains the main method.

in pre-classic versions the com/mojang/rubydung/RubyDung class contains
the main method
Copy link
Contributor

@sfPlayer1 sfPlayer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct

@Juuxel
Copy link
Member

Juuxel commented Apr 19, 2025

As far as I can tell, fixes #714, but this check will fail:

boolean isMinecraftClass = name.startsWith("net.minecraft.") || name.startsWith("com.mojang.blaze3d.") || name.indexOf('.') < 0;

(It also fails for other classic versions since the package is com.mojang.minecraft iirc).

Might be out of scope for this PR, though.

@SpaceWalkerRS
Copy link
Contributor Author

As far as I can tell, fixes #714, but this check will fail:

boolean isMinecraftClass = name.startsWith("net.minecraft.") || name.startsWith("com.mojang.blaze3d.") || name.indexOf('.') < 0;

(It also fails for other classic versions since the package is com.mojang.minecraft iirc).

Might be out of scope for this PR, though.

thanks for pointing that out, I will open a separate PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants